Mailing-List: contact issues-help@carbondata.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.incubator.apache.org
From: piaoyats <git@git.apache.org>
To: issues@carbondata.incubator.apache.org
Reply-To: issues@carbondata.incubator.apache.org
References: <git-pr-427-incubator-carbondata@git.apache.org>
In-Reply-To: <git-pr-427-incubator-carbondata@git.apache.org>
Subject: [GitHub] incubator-carbondata pull request #427: [CARBONDATA-429]reduce the no of of ...
Content-Type: text/plain
Message-Id: <20161214061232.16E3CE38C2@git1-us-west.apache.org>
Date: Wed, 14 Dec 2016 06:12:32 +0000 (UTC)
archived-at: Wed, 14 Dec 2016 06:12:36 -0000

Github user piaoyats commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/427#discussion_r92327958
  
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/GlobalDictionaryUtil.scala ---
    @@ -328,7 +328,9 @@ object GlobalDictionaryUtil {
         if (null == carbonLoadModel.getLoadMetadataDetails) {
           CommonUtil.readLoadMetadataDetails(carbonLoadModel, hdfsLocation)
         }
    -    new DictionaryLoadModel(table,
    +    val copyCarbonTableIdentifier = new CarbonTableIdentifier(table.getDatabaseName,
    +        table.getTableName, table.getTableId)
    --- End diff --
    
    why we need to copy a carbon table identifier? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---