Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3543A200BE6 for ; Sun, 11 Dec 2016 04:53:56 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 33E67160B2F; Sun, 11 Dec 2016 03:53:56 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7E645160B2B for ; Sun, 11 Dec 2016 04:53:55 +0100 (CET) Received: (qmail 6561 invoked by uid 500); 11 Dec 2016 03:53:54 -0000 Mailing-List: contact issues-help@carbondata.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@carbondata.incubator.apache.org Delivered-To: mailing list issues@carbondata.incubator.apache.org Received: (qmail 6551 invoked by uid 99); 11 Dec 2016 03:53:54 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 11 Dec 2016 03:53:54 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 2F172C02F7 for ; Sun, 11 Dec 2016 03:53:54 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -7.019 X-Spam-Level: X-Spam-Status: No, score=-7.019 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id LJOWNAFHsG75 for ; Sun, 11 Dec 2016 03:53:53 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 3FE485F4A8 for ; Sun, 11 Dec 2016 03:53:52 +0000 (UTC) Received: (qmail 6535 invoked by uid 99); 11 Dec 2016 03:53:51 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 11 Dec 2016 03:53:51 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id D22C8E108E; Sun, 11 Dec 2016 03:53:50 +0000 (UTC) From: ravipesala To: issues@carbondata.incubator.apache.org Reply-To: issues@carbondata.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-carbondata issue #368: [CARBONDATA-465] Spark streaming dataframe ... Content-Type: text/plain Message-Id: <20161211035350.D22C8E108E@git1-us-west.apache.org> Date: Sun, 11 Dec 2016 03:53:50 +0000 (UTC) archived-at: Sun, 11 Dec 2016 03:53:56 -0000 Github user ravipesala commented on the issue: https://github.com/apache/incubator-carbondata/pull/368 LGTM, Good work. But few comments like reflection is not required(can set context from initialize from RDD ) are not addressed, we can fix them in another PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---