Mailing-List: contact issues-help@carbondata.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.incubator.apache.org
From: jackylk <git@git.apache.org>
To: issues@carbondata.incubator.apache.org
Reply-To: issues@carbondata.incubator.apache.org
References: <git-pr-333-incubator-carbondata@git.apache.org>
In-Reply-To: <git-pr-333-incubator-carbondata@git.apache.org>
Subject: [GitHub] incubator-carbondata pull request #333: [CARBONDATA-471]Optimized no kettle ...
Content-Type: text/plain
Message-Id: <20161202051855.59F93E69B1@git1-us-west.apache.org>
Date: Fri,  2 Dec 2016 05:18:55 +0000 (UTC)
archived-at: Fri, 02 Dec 2016 05:18:59 -0000

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/333#discussion_r90588348
  
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/steps/InputProcessorStepImpl.java ---
    @@ -122,24 +139,52 @@ private boolean internalHasNext() {
           if (!hasNext) {
             // Check next iterator is available in the list.
             if (counter < inputIterators.size()) {
    +          // close the old iterator
    +          currentIterator.close();
               // Get the next iterator from the list.
               currentIterator = inputIterators.get(counter++);
    +          // Initialize the new iterator
    +          currentIterator.initialize();
               hasNext = internalHasNext();
             }
           }
           return hasNext;
         }
     
    -    @Override
    -    public CarbonRowBatch next() {
    -      // Create batch and fill it.
    -      CarbonRowBatch carbonRowBatch = new CarbonRowBatch();
    -      int count = 0;
    -      while (internalHasNext() && count < batchSize) {
    -        carbonRowBatch.addRow(new CarbonRow(rowParser.parseRow(currentIterator.next())));
    -        count++;
    +    @Override public CarbonRowBatch next() {
    +      CarbonRowBatch result = null;
    +      try {
    --- End diff --
    
    put override to previous line


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---