Mailing-List: contact issues-help@carbondata.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.incubator.apache.org
From: jackylk <git@git.apache.org>
To: issues@carbondata.incubator.apache.org
Reply-To: issues@carbondata.incubator.apache.org
References: <git-pr-265-incubator-carbondata@git.apache.org>
In-Reply-To: <git-pr-265-incubator-carbondata@git.apache.org>
Subject: [GitHub] incubator-carbondata pull request #265: [CARBONDATA-458]Improving First time...
Content-Type: text/plain
Message-Id: <20161201081712.98244DFC47@git1-us-west.apache.org>
Date: Thu,  1 Dec 2016 08:17:12 +0000 (UTC)
archived-at: Thu, 01 Dec 2016 08:17:18 -0000

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/265#discussion_r90399963
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
    @@ -814,85 +810,86 @@
        * Rocord size in case of compaction.
        */
       public static final int COMPACTION_INMEMORY_RECORD_SIZE = 120000;
    -
    -  /**
    -   * If the level 2 compaction is done in minor then new compacted segment will end with .2
    -   */
    -  public static String LEVEL2_COMPACTION_INDEX = ".2";
    -
    -  /**
    -   * Indicates compaction
    -   */
    -  public static String COMPACTION_KEY_WORD = "COMPACTION";
    -
       /**
        * hdfs temporary directory key
        */
       public static final String HDFS_TEMP_LOCATION = "hadoop.tmp.dir";
    -
       /**
        * zookeeper url key
        */
       public static final String ZOOKEEPER_URL = "spark.deploy.zookeeper.url";
    -
       /**
        * configure the minimum blocklet size eligible for blocklet distribution
        */
       public static final String CARBON_BLOCKLETDISTRIBUTION_MIN_REQUIRED_SIZE =
           "carbon.blockletdistribution.min.blocklet.size";
    -
       /**
        * default blocklet size eligible for blocklet distribution
        */
       public static final int DEFAULT_CARBON_BLOCKLETDISTRIBUTION_MIN_REQUIRED_SIZE = 2;
    -
    +  /**
    +   * This batch size is used to send rows from load step to another step in batches.
    +   */
    +  public static final String DATA_LOAD_BATCH_SIZE = "DATA_LOAD_BATCH_SIZE";
    +  /**
    +   * Default size of data load batch size.
    +   */
    +  public static final String DATA_LOAD_BATCH_SIZE_DEFAULT = "1000";
    +  /**
    +   * carbon data file version property
    +   */
    +  public static final String CARBON_DATA_FILE_VERSION = "carbon.data.file.version";
    +  /**
    +   * current data file version
    +   */
    +  public static final short CARBON_DATA_FILE_CURRENT_VERSION = 2;
    --- End diff --
    
    change 2 to enum also


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---