carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #471: [CARBONDATA-566] clean up code for c...
Date Tue, 27 Dec 2016 14:29:32 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/471#discussion_r93936025
  
    --- Diff: integration/spark2/src/main/java/org/apache/carbondata/spark/vectorreader/ColumnarVectorWrapper.java
---
    @@ -21,7 +21,7 @@
     import org.apache.spark.sql.execution.vectorized.ColumnVector;
     import org.apache.spark.sql.types.Decimal;
     
    -public class ColumnarVectorWrapper implements CarbonColumnVector {
    +class ColumnarVectorWrapper implements CarbonColumnVector {
    --- End diff --
    
    This is used internally only, not API. So it should not be public.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message