carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chenliang613 <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #471: [CARBONDATA-566] clean up code for c...
Date Tue, 27 Dec 2016 11:20:15 GMT
Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/471#discussion_r93921710
  
    --- Diff: integration/spark2/src/main/java/org/apache/carbondata/spark/vectorreader/ColumnarVectorWrapper.java
---
    @@ -21,7 +21,7 @@
     import org.apache.spark.sql.execution.vectorized.ColumnVector;
     import org.apache.spark.sql.types.Decimal;
     
    -public class ColumnarVectorWrapper implements CarbonColumnVector {
    +class ColumnarVectorWrapper implements CarbonColumnVector {
    --- End diff --
    
    why remove public ?  
    In the future, the class may be used by other class. suggest keep public.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message