carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #460: [CARBONDATA-560] fix QueryExecutionE...
Date Mon, 26 Dec 2016 02:36:05 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/460#discussion_r93838397
  
    --- Diff: core/src/main/java/org/apache/carbondata/scan/executor/impl/AbstractQueryExecutor.java
---
    @@ -470,7 +471,12 @@ private AggregatorInfo getAggregatorInfoForBlock(QueryModel queryModel,
        */
       @Override public void finish() throws QueryExecutionException {
         if (null != queryProperties.executorService) {
    -      queryProperties.executorService.shutdownNow();
    +      queryProperties.executorService.shutdown();
    +      try {
    +        queryProperties.executorService.awaitTermination(1, TimeUnit.HOURS);
    --- End diff --
    
    This is called when closing the reader for every query, I think timeout for 1 hour is
too long. Suggest to change to 10 seconds.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message