carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kumarvishal09 <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #454: [CARBONDATA-484] Implement LRU cache...
Date Fri, 23 Dec 2016 03:43:13 GMT
Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/454#discussion_r93727347
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/cache/CacheProvider.java ---
    @@ -121,15 +141,24 @@ private void createDictionaryCacheForGivenType(CacheType cacheType,
String carbo
        * @param cacheType
        */
       private void createLRULevelCacheInstance(CacheType cacheType) {
    -    CarbonLRUCache carbonLRUCache = null;
    -    // if cache type is dictionary cache, then same lru cache instance has to be shared
    -    // between forward and reverse cache
    -    if (cacheType.equals(CacheType.REVERSE_DICTIONARY) || cacheType
    -        .equals(CacheType.FORWARD_DICTIONARY)) {
    -      carbonLRUCache = new CarbonLRUCache(CarbonCommonConstants.CARBON_MAX_LEVEL_CACHE_SIZE,
    -          CarbonCommonConstants.CARBON_MAX_LEVEL_CACHE_SIZE_DEFAULT);
    -      cacheTypeToLRUCacheMap.put(CacheType.REVERSE_DICTIONARY, carbonLRUCache);
    -      cacheTypeToLRUCacheMap.put(CacheType.FORWARD_DICTIONARY, carbonLRUCache);
    +    boolean isDriver = Boolean.parseBoolean(CarbonProperties.getInstance()
    --- End diff --
    
    Please correct me if i am wrong If driver and executor is running under same JVM like
local mode setup then this property will be always true?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message