carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jay357089 <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #309: [CARBONDATA-402] support CreateAsSel...
Date Wed, 21 Dec 2016 02:42:39 GMT
Github user Jay357089 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/309#discussion_r93365825
  
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/CarbonOption.scala
---
    @@ -31,6 +31,10 @@ class CarbonOption(options: Map[String, String]) {
     
       def tablePath: String = s"$dbName/$tableName"
     
    +  def allowExisting: String = options.getOrElse("allowExisting", "true")
    +
    +  def tblProperties: String = options.getOrElse("tblproperties", "")
    --- End diff --
    
    it can be an option. in one way, it can  enhance dataFrame API, for example, .option("tblproperties",
"'dictionary_incdlue='id''), so that user can decide for make dict or not.  in another way,
it can support for using tableproperties when  CreateAsSelect .


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message