carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #358: [CARBONDATA-467] Adding bucketing to...
Date Tue, 20 Dec 2016 16:40:17 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/358#discussion_r93275523
  
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala
---
    @@ -93,36 +95,53 @@ class CarbonScanRDD(
         var noOfTasks = 0
     
         if (!splits.isEmpty) {
    -      // create a list of block based on split
    -      val blockList = splits.asScala.map(_.asInstanceOf[Distributable])
    -
    -      // get the list of executors and map blocks to executors based on locality
    -      val activeNodes = DistributionUtil.ensureExecutorsAndGetNodeList(blockList, sparkContext)
    -
    -      // divide the blocks among the tasks of the nodes as per the data locality
    -      val nodeBlockMapping = CarbonLoaderUtil.nodeBlockTaskMapping(blockList.asJava,
-1,
    -        parallelism, activeNodes.toList.asJava)
     
           statistic.addStatistics(QueryStatisticsConstants.BLOCK_ALLOCATION, System.currentTimeMillis)
           statisticRecorder.recordStatisticsForDriver(statistic, queryId)
           statistic = new QueryStatistic()
     
    -      var i = 0
    -      // Create Spark Partition for each task and assign blocks
    -      nodeBlockMapping.asScala.foreach { case (node, blockList) =>
    -        blockList.asScala.foreach { blocksPerTask =>
    -          val splits = blocksPerTask.asScala.map(_.asInstanceOf[CarbonInputSplit])
    -          if (blocksPerTask.size() != 0) {
    -            val multiBlockSplit = new CarbonMultiBlockSplit(identifier, splits.asJava,
node)
    -            val partition = new CarbonSparkPartition(id, i, multiBlockSplit)
    -            result.add(partition)
    -            i += 1
    +      if (bucketedTable != null) {
    +        var i = 0
    +         val bucketed =
    --- End diff --
    
    incorrect indentation


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message