carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #441: [CARBONDATA-539] Fiix column project...
Date Mon, 19 Dec 2016 14:15:26 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/441#discussion_r93038276
  
    --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/util/CarbonInputFormatUtil.java
---
    @@ -70,6 +69,18 @@ public static CarbonQueryPlan createQueryPlan(CarbonTable carbonTable,
String co
               i++;
             }
           }
    +    } else {
    +      // query all columns
    +      List<CarbonMeasure> tableMsrs = carbonTable.getMeasureByTableName(factTableName);
    --- End diff --
    
    ok, I got the issue here. Can we do like as following
    1. if it is come from count(*), we set the projection column to a special string (like
empty string "") in configuration, then we can process it differently in `createQueryPlan`.

    2. If user want to project all column, projection column should be set to null or list
all columns.
    3. If user want to project specific columns, then set it to specific columns


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message