carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #441: [CARBONDATA-539] Fiix column project...
Date Mon, 19 Dec 2016 13:31:24 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/441#discussion_r93031221
  
    --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/util/CarbonInputFormatUtil.java
---
    @@ -70,6 +69,18 @@ public static CarbonQueryPlan createQueryPlan(CarbonTable carbonTable,
String co
               i++;
             }
           }
    +    } else {
    +      // query all columns
    +      List<CarbonMeasure> tableMsrs = carbonTable.getMeasureByTableName(factTableName);
    --- End diff --
    
    It was an performance issue if all columns are added when projection is null.  That was
the reason it was removed.  Any reason it is added back?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message