carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kumarvishal09 <>
Subject [GitHub] incubator-carbondata pull request #339: [CARBONDATA-429] Remove unnecessary ...
Date Mon, 19 Dec 2016 10:36:40 GMT
Github user kumarvishal09 commented on a diff in the pull request:
    --- Diff: core/src/main/java/org/apache/carbondata/core/cache/dictionary/
    @@ -167,12 +167,9 @@ private Dictionary getDictionary(
           DictionaryColumnUniqueIdentifier dictionaryColumnUniqueIdentifier)
           throws CarbonUtilException {
         Dictionary reverseDictionary = null;
    -    // create column dictionary info object only if dictionary and its
    -    // metadata file exists for a given column identifier
    -    if (!isFileExistsForGivenColumn(dictionaryColumnUniqueIdentifier)) {
    -      throw new CarbonUtilException(
    -          "Either dictionary or its metadata does not exist for column identifier ::
    -              + dictionaryColumnUniqueIdentifier.getColumnIdentifier());
    +    // create column dictionary info object only if it is primitive type.
    +    if (dictionaryColumnUniqueIdentifier.getDataType().isComplexType()) {
    --- End diff --
    Do we need this check?? for complex data type column like array and struct no need to
invoke this class, as dictionary will be generated only for primitive type column.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message