carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #310: [CARBONDATA-401] One Pass Load
Date Fri, 16 Dec 2016 06:27:32 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/310#discussion_r92758681
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/carbon/metadata/schema/table/CarbonTable.java
---
    @@ -504,4 +521,19 @@ public void setBlockSizeInMB(int blockSize) {
         this.blockSize = blockSize;
       }
     
    +  /**
    +   * to get the all dimension of a table
    +   *
    +   * @param tableName
    +   * @return all dimension of a table
    +   */
    +  public CarbonDimension getAllDimensionByName(String tableName, String columnName) {
    --- End diff --
    
    This function is not getting all dimensions, it is used for finding the specified column,
right? I think there is already a function called `getDimensionByName` to provide this functionality


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message