carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From foryou2030 <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #436: [CARBONDATA-532] [WIP] fix bigdecima...
Date Thu, 15 Dec 2016 01:39:34 GMT
Github user foryou2030 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/436#discussion_r92528784
  
    --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala
---
    @@ -436,17 +436,17 @@ case class LoadTable(
           val columinar = sqlContext.getConf("carbon.is.columnar.storage", "true").toBoolean
     
           // TODO It will be removed after kettle is removed.
    -      val useKettle = options.get("useKettle") match {
    -        case Some(value) => value.toBoolean
    -        case _ =>
    -          val useKettleLocal = System.getProperty("use.kettle")
    -          if (useKettleLocal == null) {
    -            sqlContext.sparkContext.getConf.get("use_kettle_default", "true").toBoolean
    -          } else {
    -            useKettleLocal.toBoolean
    -          }
    -      }
    -
    +//      val useKettle = options.get("useKettle") match {
    +//        case Some(value) => value.toBoolean
    +//        case _ =>
    +//          val useKettleLocal = System.getProperty("use.kettle")
    +//          if (useKettleLocal == null) {
    +//            sqlContext.sparkContext.getConf.get("use_kettle_default", "true").toBoolean
    +//          } else {
    +//            useKettleLocal.toBoolean
    +//          }
    +//      }
    --- End diff --
    
    hi, @ravindra, the comment is for verify all test case when use_kettle=false.
    and i found that, some commits introduced issues, due to lack of consideration of the
new flow


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message