carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From piaoyats <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #339: [CARBONDATA-429][WIP] Remove unneces...
Date Wed, 14 Dec 2016 07:02:15 GMT
Github user piaoyats commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/339#discussion_r92331735
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/cache/dictionary/ReverseDictionaryCache.java
---
    @@ -167,12 +167,9 @@ private Dictionary getDictionary(
           DictionaryColumnUniqueIdentifier dictionaryColumnUniqueIdentifier)
           throws CarbonUtilException {
         Dictionary reverseDictionary = null;
    -    // create column dictionary info object only if dictionary and its
    -    // metadata file exists for a given column identifier
    -    if (!isFileExistsForGivenColumn(dictionaryColumnUniqueIdentifier)) {
    -      throw new CarbonUtilException(
    -          "Either dictionary or its metadata does not exist for column identifier ::
"
    -              + dictionaryColumnUniqueIdentifier.getColumnIdentifier());
    +    // create column dictionary info object only if it is primitive type.
    +    if (dictionaryColumnUniqueIdentifier.getDataType().isComplexType()) {
    +      return null;
    --- End diff --
    
    I am not sure this condition check is right or not? Maybe we still need to do dictionary
encoding for complex type?
    @QiangCai  pls review this logic


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message