carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From piaoyats <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #388: [CARBONDATA-431]bigdecimal compressi...
Date Tue, 13 Dec 2016 03:00:35 GMT
Github user piaoyats commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/388#discussion_r92089924
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/ValueCompressionUtil.java
---
    @@ -196,6 +198,31 @@ private static CompressionFinder getDoubleCompressorFinder(Object
maxValue, Obje
         }
       }
     
    +  private static CompressionFinder getBigDecimalCompressorFinder(
    +      Object maxValue, Object minValue, int decimal, byte dataTypeSelected) {
    --- End diff --
    
    change decimal to mantissa, keep same with others


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message