carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From piaoyats <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #388: [CARBONDATA-431]bigdecimal compressi...
Date Tue, 13 Dec 2016 02:58:03 GMT
Github user piaoyats commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/388#discussion_r92089699
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/ValueCompressionUtil.java
---
    @@ -138,8 +141,7 @@ public static CompressionFinder getCompressionFinder(Object maxValue,
Object min
         // ''b' for decimal, 'l' for long, 'n' for double
         switch (measureStoreType) {
           case 'b':
    -        return new CompressionFinder(COMPRESSION_TYPE.BIGDECIMAL, DataType.DATA_BYTE,
    -            DataType.DATA_BYTE);
    +        return getBigDecimalCompressorFinder(maxValue, minValue, 0, dataTypeSelected);
    --- End diff --
    
    if mantissa equals to 0 hear for big decimal? if it is, keep passing mantissa to getBigDecimalCompressorFinder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message