carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From piaoyats <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #388: [CARBONDATA-431]bigdecimal compressi...
Date Tue, 13 Dec 2016 02:49:16 GMT
Github user piaoyats commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/388#discussion_r92088924
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/BigDecimalCompressionFinder.java
---
    @@ -0,0 +1,79 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.carbondata.core.util;
    +
    +import org.apache.carbondata.core.util.ValueCompressionUtil.COMPRESSION_TYPE;
    +import org.apache.carbondata.core.util.ValueCompressionUtil.DataType;
    +
    +public class BigDecimalCompressionFinder extends CompressionFinder {
    +
    +  private COMPRESSION_TYPE leftCompType;
    +
    +  private COMPRESSION_TYPE rightCompType;
    +
    +  private DataType leftActualDataType;
    +
    +  private DataType rightActualDataType;
    --- End diff --
    
    what does the ActualDataType and ChangedDataType mean?     Does actualDataType mean original
data type and changedDataType is the type we store?  suggest we rename the variables more
readable


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message