carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #388: [CARBONDATA-431]bigdecimal compressi...
Date Tue, 13 Dec 2016 01:22:34 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/388#discussion_r92079674
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/compression/BigIntCompressor.java
---
    @@ -44,6 +44,11 @@ protected Object compressMaxMin(DataType changedDataType, CarbonWriteDataHolder
           Object max) {
         long maxValue = (long) max;
         long[] value = dataHolder.getWritableLongValues();
    +    return compressMaxMin(changedDataType, maxValue, value);
    +  }
    +
    +  protected Object compressMaxMin(DataType changedDataType, long maxValue,
    --- End diff --
    
    please add description to these compress functions, make it easier to understand by reader


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message