carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From scwf <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #417: fix conf issue for scanrdd
Date Sun, 11 Dec 2016 05:57:46 GMT
Github user scwf commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/417#discussion_r91848570
  
    --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/CarbonEnv.scala ---
    @@ -21,22 +21,24 @@ import org.apache.spark.scheduler.cluster.CoarseGrainedSchedulerBackend
     import org.apache.spark.sql.hive.CarbonMetastore
     
     import org.apache.carbondata.hadoop.readsupport.impl.RawDataReadSupport
    -import org.apache.carbondata.spark.rdd.SparkCommonEnv
    +import org.apache.carbondata.spark.rdd.SparkReadSupport
     
     case class CarbonEnv(carbonMetastore: CarbonMetastore)
     
     object CarbonEnv {
     
       @volatile private var carbonEnv: CarbonEnv = _
     
    +  // set readsupport class global so that the executor can get it.
    +  SparkReadSupport.readSupportClass = classOf[RawDataReadSupport]
    --- End diff --
    
    No, this is the key point, init is called in driver, see the comment, place here is to
let executor get the read support class


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message