carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #389: [CARBONDATA-491] spark2 integration:...
Date Sun, 04 Dec 2016 13:28:35 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/389#discussion_r90777384
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonEnv.scala ---
    @@ -17,19 +17,20 @@
     
     package org.apache.spark.sql
     
    -import org.apache.spark.SparkContext
    -import org.apache.spark.internal.Logging
     import org.apache.spark.scheduler.cluster.CoarseGrainedSchedulerBackend
     import org.apache.spark.sql.hive.{CarbonMetastore, DistributionUtil}
     
    +import org.apache.carbondata.common.logging.LogServiceFactory
     import org.apache.carbondata.core.constants.CarbonCommonConstants
     
     /**
      * Carbon Environment for unified context
      */
     case class CarbonEnv(carbonMetastore: CarbonMetastore)
     
    -object CarbonEnv extends Logging {
    +object CarbonEnv {
    +
    +  val Logger = LogServiceFactory.getLogService(this.getClass.getName)
    --- End diff --
    
    declare as private and change to `LOGGER`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message