carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From PallaviSingh1992 <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #336: [CARBONDATA-426] replace if else wit...
Date Fri, 02 Dec 2016 05:46:40 GMT
Github user PallaviSingh1992 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/336#discussion_r90590085
  
    --- Diff: integration/spark-common/src/main/java/org/apache/carbondata/spark/merger/CarbonCompactionUtil.java
---
    @@ -142,20 +142,14 @@ private static void groupCorrespodingInfoBasedOnTask(TableBlockInfo
info,
        * @return
        */
       public static boolean isCompactionRequiredForTable(String metaFolderPath) {
    -    String minorCompactionStatusFile = metaFolderPath + CarbonCommonConstants.FILE_SEPARATOR
    -        + CarbonCommonConstants.minorCompactionRequiredFile;
    -
    -    String majorCompactionStatusFile = metaFolderPath + CarbonCommonConstants.FILE_SEPARATOR
    -        + CarbonCommonConstants.majorCompactionRequiredFile;
    +    String statusFile = metaFolderPath + CarbonCommonConstants.FILE_SEPARATOR;
         try {
    -      if (FileFactory.isFileExist(minorCompactionStatusFile,
    -          FileFactory.getFileType(minorCompactionStatusFile)) || FileFactory
    -          .isFileExist(majorCompactionStatusFile,
    -              FileFactory.getFileType(majorCompactionStatusFile))) {
    -        return true;
    -      }
    +      return (FileFactory.isFileExist(statusFile + CarbonCommonConstants.minorCompactionRequiredFile,
    --- End diff --
    
    I will revert back to original code


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message