carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #333: [CARBONDATA-471]Optimized no kettle ...
Date Fri, 02 Dec 2016 05:18:08 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/333#discussion_r90588312
  
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/steps/InputProcessorStepImpl.java
---
    @@ -80,40 +87,50 @@ public void initialize() throws CarbonDataLoadingException {
         return iterators;
       }
     
    -  @Override
    -  protected CarbonRow processRow(CarbonRow row) {
    +  @Override protected CarbonRow processRow(CarbonRow row) {
         return null;
       }
     
    +  @Override public void close() {
    +    executorService.shutdown();
    +  }
    +
       /**
        * This iterator wraps the list of iterators and it starts iterating the each
        * iterator of the list one by one. It also parse the data while iterating it.
        */
       private static class InputProcessorIterator extends CarbonIterator<CarbonRowBatch>
{
     
    -    private List<Iterator<Object[]>> inputIterators;
    +    private List<InputIterator<Object[]>> inputIterators;
     
    -    private Iterator<Object[]> currentIterator;
    +    private InputIterator<Object[]> currentIterator;
     
         private int counter;
     
         private int batchSize;
     
         private RowParser rowParser;
     
    -    public InputProcessorIterator(List<Iterator<Object[]>> inputIterators,
    -        RowParser rowParser, int batchSize) {
    +    private Future<CarbonRowBatch> future;
    +
    +    private ExecutorService executorService;
    +
    +    private boolean nextBatch = false;
    --- End diff --
    
    initialize in constructor, like counter


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message