carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kumarvishal09 <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #265: [CARBONDATA-458]Improving First time...
Date Thu, 01 Dec 2016 05:36:46 GMT
Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/265#discussion_r90386030
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/carbon/datastore/block/TableBlockInfo.java
---
    @@ -81,13 +84,14 @@ public TableBlockInfo(String filePath, long blockOffset, String segmentId,
Strin
        * @param blockletInfos
        */
       public TableBlockInfo(String filePath, long blockOffset, String segmentId, String[]
locations,
    -      long blockLength, BlockletInfos blockletInfos) {
    +      long blockLength, BlockletInfos blockletInfos, short version) {
         this.filePath = FileFactory.getUpdatedFilePath(filePath);
         this.blockOffset = blockOffset;
         this.segmentId = segmentId;
         this.locations = locations;
         this.blockLength = blockLength;
         this.blockletInfos = blockletInfos;
    +    this.version = version;
    --- End diff --
    
    validateCarbonDataFileVersion method is CrabonProperties I am validating the version


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message