Mailing-List: contact issues-help@carbondata.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.incubator.apache.org
From: sujith71955 <git@git.apache.org>
To: issues@carbondata.incubator.apache.org
Reply-To: issues@carbondata.incubator.apache.org
References: <git-pr-332-incubator-carbondata@git.apache.org>
In-Reply-To: <git-pr-332-incubator-carbondata@git.apache.org>
Subject: [GitHub] incubator-carbondata pull request #332: [CARBONDATA-424] Data Load will fail...
Content-Type: text/plain
Message-Id: <20161119121837.65755E08F2@git1-us-west.apache.org>
Date: Sat, 19 Nov 2016 12:18:37 +0000 (UTC)
archived-at: Sat, 19 Nov 2016 12:19:19 -0000

Github user sujith71955 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/332#discussion_r88778379
  
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/surrogatekeysgenerator/csvbased/BadRecordsLogger.java ---
    @@ -87,22 +87,25 @@
     
       private boolean badRecordConvertNullDisable;
     
    +  private boolean isDataLoadFail;
    +
       // private final Object syncObject =new Object();
     
       public BadRecordsLogger(String key, String fileName, String storePath,
           boolean badRecordsLogRedirect, boolean badRecordLoggerEnable,
    -      boolean badRecordConvertNullDisable) {
    +      boolean badRecordConvertNullDisable, boolean isDataLoadFail) {
    --- End diff --
    
    Please set  this bad records related properties to a bad record type VO object and pass the VO object as argument for better maintanability, else the arguments in constructor will be increasing in future.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---