carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CARBONDATA-384) Add Table Properties Options Validation
Date Mon, 07 Nov 2016 04:03:58 GMT

    [ https://issues.apache.org/jira/browse/CARBONDATA-384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15643034#comment-15643034
] 

ASF GitHub Bot commented on CARBONDATA-384:
-------------------------------------------

GitHub user lion-x opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/299

    [CARBONDATA-384]Add Table Properties Options Validation

    # Why raise this PR?
    Now, Carbon does not validate the table properties options. This will cause below problem.
    For example,
    Create table carbontable (.......)
    TBLPROPERTIES ('DICTIONARY_EXELUDE'='colname');
    user wants to use DICTIONARY_EXCLUDE property, but he types a wrong option name, the setting
will be ignored with no error throw.
    
    # How to test?
    Pass all test case.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lion-x/incubator-carbondata validateTblOptions

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/299.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #299
    
----
commit f19122e5441835a9a4298fb327eb80c373810e6e
Author: lion-x <xlion.pku@gmail.com>
Date:   2016-11-07T04:00:19Z

    validateTblOptions

----


> Add Table Properties Options Validation
> ---------------------------------------
>
>                 Key: CARBONDATA-384
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-384
>             Project: CarbonData
>          Issue Type: Improvement
>            Reporter: Lionx
>            Assignee: Lionx
>            Priority: Minor
>
> Now, Carbon does not validate the table properties options. This will cause below problem.
> For example,
> Create table carbontable (.......)
> TBLPROPERTIES ('DICTIONARY_EXELUDE'='colname');
> user wants to use DICTIONARY_EXCLUDE property, but he types a wrong option name, the
setting will be ignored with no error throw.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message