carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CARBONDATA-383) Optimize hdfsStoreLocation/hdfsStorePath parameters' name since Carbon not only support hdfs path
Date Sat, 05 Nov 2016 19:04:58 GMT

    [ https://issues.apache.org/jira/browse/CARBONDATA-383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15640369#comment-15640369
] 

ASF GitHub Bot commented on CARBONDATA-383:
-------------------------------------------

GitHub user Hexiaoqiao opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/298

    [CARBONDATA-383]Optimize hdfsStoreLocation/hdfsStorePath parameters' name since Carbon
not only support hdfs path

    change parameters' name from hdfsStoreLocation/hdfsStorePath to storePath in order to
avoid ambiguity.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Hexiaoqiao/incubator-carbondata carbon-dev

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/298.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #298
    
----
commit af810f8964772ee95dc6525375cae13010521604
Author: hexiaoqiao <hexiaoqiao@meituan.com>
Date:   2016-10-28T14:44:57Z

    CARBONDATA-343 delete some duplicated definition code

commit 5c9775d0f51baafb04423330591c8d90df9ebdff
Author: hexiaoqiao <hexiaoqiao@meituan.com>
Date:   2016-10-28T14:52:51Z

    CARBONDATA-343 delete some duplicated definition code

commit 03caa6211d1bd239d8331ad490904223267eee4a
Author: hexiaoqiao <hexiaoqiao@meituan.com>
Date:   2016-11-05T18:44:08Z

    Optimize hdfsStoreLocation parameters' name since Carbon not only support hdfs path

commit 1768fe5406f02b1e829226ffda28ba0a86459828
Author: hexiaoqiao <hexiaoqiao@meituan.com>
Date:   2016-11-05T18:45:09Z

    Merge branch 'carbon-dev' of github.com:Hexiaoqiao/incubator-carbondata into carbon-dev

----


> Optimize hdfsStoreLocation/hdfsStorePath parameters' name since Carbon not only support
hdfs path
> -------------------------------------------------------------------------------------------------
>
>                 Key: CARBONDATA-383
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-383
>             Project: CarbonData
>          Issue Type: Improvement
>          Components: core
>            Reporter: He Xiaoqiao
>            Assignee: He Xiaoqiao
>            Priority: Minor
>
> Optimize hdfsStoreLocation/hdfsStorePath parameters' name since Carbon not only support
hdfs path.
> Currently, Carbon can support hdfs/viewfs schema and alluxio will be later, ref [CARBONDATA-367|https://issues.apache.org/jira/browse/CARBONDATA-367].
So change parameters' name (hdfsStoreLocation/hdfsStorePath) to storePath in order to avoid
ambiguity.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message