carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CARBONDATA-362) Optimize the parameters' name in CarbonDataRDDFactory.scala
Date Thu, 03 Nov 2016 02:42:58 GMT

    [ https://issues.apache.org/jira/browse/CARBONDATA-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15631315#comment-15631315
] 

ASF GitHub Bot commented on CARBONDATA-362:
-------------------------------------------

Github user Hexiaoqiao commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/281#discussion_r86279989
  
    --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala
---
    @@ -65,7 +65,7 @@ object CarbonDataRDDFactory extends Logging {
           sqlContext: SQLContext,
           carbonLoadModel: CarbonLoadModel,
           storeLocation: String,
    -      hdfsStoreLocation: String,
    +      StoreLocation: String,
    --- End diff --
    
    pls follow the code style and use lowercase character of variable.


> Optimize the parameters' name in CarbonDataRDDFactory.scala
> -----------------------------------------------------------
>
>                 Key: CARBONDATA-362
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-362
>             Project: CarbonData
>          Issue Type: Bug
>            Reporter: Liang Chen
>            Assignee: He Xiaoqiao
>            Priority: Trivial
>
> Optimize the parameters' name in CarbonDataRDDFactory.scala:
> changes the name of "hdfsStoreLocation"  to "storePath", because not only support hdfs
path.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message