carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CARBONDATA-328) Improve Code and Fix Warnings
Date Wed, 02 Nov 2016 10:01:10 GMT

    [ https://issues.apache.org/jira/browse/CARBONDATA-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15628430#comment-15628430
] 

ASF GitHub Bot commented on CARBONDATA-328:
-------------------------------------------

GitHub user PKOfficial opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/279

    [CARBONDATA-328] [Spark] Improve Code and Fix Warnings [Squashed]

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[CARBONDATA-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
     - [ ] Testing done
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella
JIRA. 
     
    **Please provide details on**
    - **Whether new unit test cases have been added or why no new tests are required?**
    Not required because no change in functionality.
    - **What manual testing you have done?**
    Run basic Commands in Beeline.
    - **Any additional information to help reviewers in testing this change.**
    No
                     
    ---
    Improved spark module code.
        * Removed some compliation warnings.
        * Replace pattern matching for boolean to IF-ELSE.
        * Improved code according to scala standards.
        * Removed unnecessary new lines.
        * Added string interpolation instead of string concatenation.
        * Removed unnecessary semi-colons.
        * Fixed indentation.
        * add useKettle option for loading
        * Fixed indentation.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/PKOfficial/incubator-carbondata improved-code

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/279.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #279
    
----
commit 044260fc7265251be097d6544dade1bc4db1e3a0
Author: X-Lion <xlion.pku@gmail.com>
Date:   2016-09-29T14:33:18Z

    Lionx0929
    
    mend

commit 2fd3cd566eec870d7e2601b3bdc66496fa509377
Author: ravipesala <ravi.pesala@gmail.com>
Date:   2016-10-20T02:41:46Z

    Added Writer processor step for dataloading.
    
    Rebased Fixed comments.
    
    Added factory for fact data handler
    
    Fixed review comments.
    
    Fixed compilation issue after rebase

commit a982583720c83bbf558f6fc1404078b5bbffaa15
Author: hexiaoqiao <hexiaoqiao@meituan.com>
Date:   2016-10-28T14:44:57Z

    CARBONDATA-343 delete some duplicated definition code
    
    CARBONDATA-343 delete some duplicated definition code

commit 1be29a884a5ab00b970fea7c3901f8acf0a13465
Author: Prabhat Kashyap <prabhat.kashyap@knoldus.in>
Date:   2016-10-19T16:54:47Z

    Improved spark module code.
    * Removed some compliation warnings.
    * Replace pattern matching for boolean to IF-ELSE.
    * Improved code according to scala standards.
    * Removed unnecessary new lines.
    * Added string interpolation instead of string concatenation.
    * Removed unnecessary semi-colons.
    * Fixed indentation.
    * add useKettle option for loading
    * Fixed indentation.

----


> Improve Code and Fix Warnings
> -----------------------------
>
>                 Key: CARBONDATA-328
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-328
>             Project: CarbonData
>          Issue Type: Improvement
>            Reporter: Prabhat Kashyap
>            Priority: Trivial
>
> Remove compiler warning and improve the existing code according to the standards. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message