carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CARBONDATA-276) Add trim option
Date Tue, 01 Nov 2016 15:50:58 GMT

    [ https://issues.apache.org/jira/browse/CARBONDATA-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15625765#comment-15625765
] 

ASF GitHub Bot commented on CARBONDATA-276:
-------------------------------------------

Github user sujith71955 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/200#discussion_r85957010
  
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/graphgenerator/GraphGenerator.java
---
    @@ -998,4 +1000,24 @@ private void prepareIsUseInvertedIndex(List<CarbonDimension>
dims,
         graphConfig.setIsUseInvertedIndex(
             isUseInvertedIndexList.toArray(new Boolean[isUseInvertedIndexList.size()]));
       }
    +
    +  /**
    +   * Preparing the boolean [] to map whether the dimension use trim or not.
    +   *
    +   * @param dims
    +   * @param graphConfig
    +   */
    +  private void prepareIsUseTrim(List<CarbonDimension> dims,
    +                                GraphConfigurationInfo graphConfig) {
    +    List<Boolean> isUseTrimList = new ArrayList<Boolean>();
    +    for (CarbonDimension dimension : dims) {
    +      if (dimension.isUseTrim()) {
    --- End diff --
    
    Can we add this trim option as property of the column, i mean inside a column property
rather than setting directly as CarbonDimension property, Already in CarbonColumn there is
a property map which holds column related properties, i think we can use that, please check
the feasibility.


> Add trim option
> ---------------
>
>                 Key: CARBONDATA-276
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-276
>             Project: CarbonData
>          Issue Type: Bug
>            Reporter: Lionx
>            Assignee: Lionx
>            Priority: Minor
>
> Fix a bug and add trim option.
> Bug: When string is contains LeadingWhiteSpace or TrailingWhiteSpace, query result is
null. This is because the dictionary ignore the LeadingWhiteSpace and TrailingWhiteSpace and
the csvInput dose not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message