carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #265: [CARBONDATA-458]Improving First time...
Date Wed, 30 Nov 2016 15:01:23 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/265#discussion_r90249003
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/carbon/datastore/chunk/reader/measure/AbstractMeasureChunkReader.java
---
    @@ -18,58 +18,27 @@
      */
     package org.apache.carbondata.core.carbon.datastore.chunk.reader.measure;
     
    -import java.util.List;
    -
     import org.apache.carbondata.core.carbon.datastore.chunk.reader.MeasureColumnChunkReader;
    -import org.apache.carbondata.core.carbon.metadata.blocklet.datachunk.DataChunk;
    -import org.apache.carbondata.core.datastorage.store.compression.ValueCompressionModel;
    -import org.apache.carbondata.core.datastorage.store.compression.ValueCompressonHolder;
    -import org.apache.carbondata.core.datastorage.store.compression.ValueCompressonHolder.UnCompressValue;
     
     /**
      * Measure block reader abstract class
      */
     public abstract class AbstractMeasureChunkReader implements MeasureColumnChunkReader
{
    --- End diff --
    
    It seems this class is not implementing any interface function of `MeasureColumnChunkReader`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message