carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #368: [CARBONDATA-465] Spark streaming dat...
Date Wed, 30 Nov 2016 09:37:39 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/368#discussion_r90197023
  
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java
---
    @@ -604,4 +606,33 @@ public static boolean isHeaderValid(String tableName, String header,
         }
         return dateformatsHashMap;
       }
    +
    --- End diff --
    
    This reflection code is not required. Please check how load happens through dataframe
in CarbonDataLoadRDD. I guess you can make use of same code.
    And your iterator supposed to extend `InputIterator` of PR33.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message