carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #368: [CARBONDATA-465] Spark streaming dat...
Date Wed, 30 Nov 2016 09:26:19 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/368#discussion_r90195041
  
    --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/hive/CarbonMetastoreCatalog.scala
---
    @@ -307,10 +307,17 @@ class CarbonMetastoreCatalog(hiveContext: HiveContext, val storePath:
String,
         if (!FileFactory.isFileExist(schemaMetadataPath, fileType)) {
           FileFactory.mkdirs(schemaMetadataPath, fileType)
         }
    +
    +    /**
    +    * schemaFilePath starts with file:// will not create meta files successfully
    +    * while thriftWriter will have no complains.
    +    * This will cause some weired error eg. No table found.
    +    */
    --- End diff --
    
    Better don't keep comment like this. Please raise jira and provide steps to reproduce
it. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message