carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] incubator-carbondata pull request #309: [CARBONDATA-402] support CreateAsSel...
Date Sat, 19 Nov 2016 01:50:00 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/309#discussion_r88768877
  
    --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/CarbonSqlParser.scala
---
    @@ -412,24 +413,34 @@ class CarbonSqlParser()
                 case Token("TOK_LIKETABLE", child :: Nil) =>
                   likeTableName = child.getChild(0).getText()
     
    +            case Token("TOK_QUERY", _) =>
    +              isCreateAsSelect = true
    +
                 case _ => // Unsupport features
               }
     
    -
    -          // validate tblProperties
    -          if (!CommonUtil.validateTblProperties(tableProperties, fields)) {
    -            throw new MalformedCarbonCommandException("Invalid table properties")
    +          if (isCreateAsSelect) {
    +            CreateCarbonTableAsSelect(
    --- End diff --
    
    There is no table property for CreateTableAsSelect? How if user want to exclude some dictionary?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message