Mailing-List: contact issues-help@carbondata.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.incubator.apache.org
Date: Thu, 20 Oct 2016 15:55:58 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@carbondata.incubator.apache.org
Message-ID: <JIRA.13013621.1476903865000.40664.1476978958375@Atlassian.JIRA>
In-Reply-To: <JIRA.13013621.1476903865000@Atlassian.JIRA>
References: <JIRA.13013621.1476903865000@Atlassian.JIRA> <JIRA.13013621.1476903865358@arcas>
Subject: [jira] [Commented] (CARBONDATA-329) constant final class changed to
 interface
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 20 Oct 2016 15:56:04 -0000


    [ https://issues.apache.org/jira/browse/CARBONDATA-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15592192#comment-15592192 ] 

ASF GitHub Bot commented on CARBONDATA-329:
-------------------------------------------

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/249#discussion_r84315712
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
    @@ -19,866 +19,859 @@
     
     package org.apache.carbondata.core.constants;
     
    -public final class CarbonCommonConstants {
    +public interface CarbonCommonConstants {
    --- End diff --
    
    why to change it to interface? I do not think it is a good approach to keep constant value inside interface


> constant final class changed to interface
> -----------------------------------------
>
>                 Key: CARBONDATA-329
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-329
>             Project: CarbonData
>          Issue Type: Improvement
>          Components: core
>            Reporter: abhishek
>            Priority: Trivial
>
> Constant file's is final class and it is now changed to interface. Implicitly fields are static and final.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)