Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 74707200BA8 for ; Mon, 24 Oct 2016 15:04:24 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 73113160AEB; Mon, 24 Oct 2016 13:04:24 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B9714160AE1 for ; Mon, 24 Oct 2016 15:04:23 +0200 (CEST) Received: (qmail 1410 invoked by uid 500); 24 Oct 2016 13:04:21 -0000 Mailing-List: contact issues-help@carbondata.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@carbondata.incubator.apache.org Delivered-To: mailing list issues@carbondata.incubator.apache.org Received: (qmail 1396 invoked by uid 99); 24 Oct 2016 13:04:21 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Oct 2016 13:04:21 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 61D121A02F6 for ; Mon, 24 Oct 2016 13:04:19 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -7.019 X-Spam-Level: X-Spam-Status: No, score=-7.019 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id I_x-4M8JCwlQ for ; Mon, 24 Oct 2016 13:04:17 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 8C75B5FC42 for ; Mon, 24 Oct 2016 13:04:15 +0000 (UTC) Received: (qmail 98699 invoked by uid 99); 24 Oct 2016 13:02:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Oct 2016 13:02:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 9C25F2C0D55 for ; Mon, 24 Oct 2016 13:02:58 +0000 (UTC) Date: Mon, 24 Oct 2016 13:02:58 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@carbondata.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CARBONDATA-328) Improve Code and Fix Warnings MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 24 Oct 2016 13:04:24 -0000 [ https://issues.apache.org/jira/browse/CARBONDATA-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15601922#comment-15601922 ] ASF GitHub Bot commented on CARBONDATA-328: ------------------------------------------- Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/248#discussion_r84681517 --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala --- @@ -188,16 +194,16 @@ object CarbonDataRDDFactory extends Logging { newSplitSize = CarbonCommonConstants.CARBON_16MB } hadoopConfiguration.set(FileInputFormat.SPLIT_MAXSIZE, newSplitSize.toString) - logInfo("totalInputSpaceConsumed : " + spaceConsumed + - " , defaultParallelism : " + defaultParallelism) - logInfo("mapreduce.input.fileinputformat.split.maxsize : " + newSplitSize.toString) + logInfo(s"totalInputSpaceConsumed : $spaceConsumed ," + --- End diff -- remove space before `:` and make this log in one line > Improve Code and Fix Warnings > ----------------------------- > > Key: CARBONDATA-328 > URL: https://issues.apache.org/jira/browse/CARBONDATA-328 > Project: CarbonData > Issue Type: Improvement > Reporter: Prabhat Kashyap > Priority: Trivial > > Remove compiler warning and improve the existing code according to the standards. -- This message was sent by Atlassian JIRA (v6.3.4#6332)