Mailing-List: contact issues-help@carbondata.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.incubator.apache.org
Date: Fri, 14 Oct 2016 05:35:20 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@carbondata.incubator.apache.org
Message-ID: <JIRA.13011233.1476155970000.826331.1476423320861@Atlassian.JIRA>
In-Reply-To: <JIRA.13011233.1476155970000@Atlassian.JIRA>
References: <JIRA.13011233.1476155970000@Atlassian.JIRA> <JIRA.13011233.1476155970046@arcas>
Subject: [jira] [Commented] (CARBONDATA-296) 1.Add CSVInputFormat to read
 csv files.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 14 Oct 2016 05:35:25 -0000


    [ https://issues.apache.org/jira/browse/CARBONDATA-296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15574279#comment-15574279 ] 

ASF GitHub Bot commented on CARBONDATA-296:
-------------------------------------------

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/233#discussion_r83355842
  
    --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/io/StringArrayWritable.java ---
    @@ -0,0 +1,69 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.carbondata.hadoop.io;
    +
    +import java.io.DataInput;
    +import java.io.DataOutput;
    +import java.io.IOException;
    +import java.nio.charset.Charset;
    +import java.util.Arrays;
    +
    +import org.apache.hadoop.io.Writable;
    +
    +/**
    + * A String sequence that is usable as a key or value.
    + */
    +public class StringArrayWritable implements Writable {
    +  private String[] values;
    +
    +  public String[] toStrings() {
    +    return values;
    +  }
    +
    +  public void set(String[] values) {
    +    this.values = values;
    +  }
    +
    +  public String[] get() {
    +    return values;
    +  }
    +
    +  @Override public void readFields(DataInput in) throws IOException {
    --- End diff --
    
    `@Override` should be put to previous line


> 1.Add CSVInputFormat to read csv files.
> ---------------------------------------
>
>                 Key: CARBONDATA-296
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-296
>             Project: CarbonData
>          Issue Type: Sub-task
>            Reporter: Ravindra Pesala
>            Assignee: QiangCai
>             Fix For: 0.2.0-incubating
>
>
> Add CSVInputFormat to read csv files, it should use Univocity parser to read csv files to get optimal performance. 


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)