Mailing-List: contact issues-help@carbondata.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.incubator.apache.org
Date: Fri, 28 Oct 2016 02:05:58 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@carbondata.incubator.apache.org
Message-ID: <JIRA.12986776.1467715704000.113115.1477620358508@Atlassian.JIRA>
In-Reply-To: <JIRA.12986776.1467715704000@Atlassian.JIRA>
References: <JIRA.12986776.1467715704000@Atlassian.JIRA> <JIRA.12986776.1467715704686@arcas>
Subject: [jira] [Commented] (CARBONDATA-37) Support Date/Time format for
 Timestamp columns to be defined at column level
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 28 Oct 2016 02:06:03 -0000


    [ https://issues.apache.org/jira/browse/CARBONDATA-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15613999#comment-15613999 ] 

ASF GitHub Bot commented on CARBONDATA-37:
------------------------------------------

Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/219#discussion_r85460571
  
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/surrogatekeysgenerator/csvbased/CarbonCSVBasedSeqGenStep.java ---
    @@ -1176,11 +1215,8 @@ else if(isComplexTypeColumn[j]) {
                 }
                 ColumnSchemaDetails details = columnSchemaDetailsWrapper.get(dimensionColumnIds[m]);
                 if (details.isDirectDictionary()) {
    -              DirectDictionaryGenerator directDictionaryGenerator1 =
    -                  DirectDictionaryKeyGeneratorFactory
    -                      .getDirectDictionaryGenerator(details.getColumnType());
                   surrogateKeyForHrrchy[0] =
    -                  directDictionaryGenerator1.generateDirectSurrogateKey(tuple);
    +              directDictionaryGenerators[m].generateDirectSurrogateKey(tuple);
    --- End diff --
    
    take care code style


> Support Date/Time format for Timestamp columns to be defined at column level
> ----------------------------------------------------------------------------
>
>                 Key: CARBONDATA-37
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-37
>             Project: CarbonData
>          Issue Type: Improvement
>            Reporter: Vimal Das Kammath
>            Assignee: Lionx
>
> Carbon support defining the Date/Time format. But the configuration for the same is present in carbon.properties and hence is global for all tables.
> This global configuration for timestamp format cannot support scenarios where different tables or different Timestamp columns in the same table.
> Suggest to provide option in the create table DDL itself to define the format for each Timestamp column. Also provide defaults so that users can create table with Timestamp columns without having to always define the Date/Time format.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)