carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CARBONDATA-338) Remove the method arguments as they are never used inside the method
Date Wed, 26 Oct 2016 08:04:58 GMT

    [ https://issues.apache.org/jira/browse/CARBONDATA-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15607808#comment-15607808
] 

ASF GitHub Bot commented on CARBONDATA-338:
-------------------------------------------

GitHub user shiv4nsh opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/258

    [CARBONDATA-338] Removed the unused value inside the method

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[CARBONDATA-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
     - [ ] Testing done
     
            Please provide details on 
            - Whether new unit test cases have been added or why no new tests are required?
            - What manual testing you have done?
            - Any additional information to help reviewers in testing this change.
             
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella
JIRA. 
                     
    ---
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shiv4nsh/incubator-carbondata improvement/CARBONDATA-338

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/258.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #258
    
----
commit 97cdfdc6bd4fc112253437628683d8fbdaab8c6f
Author: Knoldus <shiv4nsh@gmail.com>
Date:   2016-10-26T08:01:35Z

    Removed the unused value inside the method

----


> Remove the method arguments as they are never used inside the method
> --------------------------------------------------------------------
>
>                 Key: CARBONDATA-338
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-338
>             Project: CarbonData
>          Issue Type: Improvement
>          Components: core
>            Reporter: Shivansh
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message