carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CARBONDATA-329) constant final class changed to interface
Date Sat, 22 Oct 2016 01:48:58 GMT

    [ https://issues.apache.org/jira/browse/CARBONDATA-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15596922#comment-15596922
] 

ASF GitHub Bot commented on CARBONDATA-329:
-------------------------------------------

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/249#discussion_r84567557
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
    @@ -19,866 +19,859 @@
     
     package org.apache.carbondata.core.constants;
     
    -public final class CarbonCommonConstants {
    +public interface CarbonCommonConstants {
    --- End diff --
    
    @ravipesala @gvramana @Vimal-Das 
    What is your opinion. Refer to [this](http://stackoverflow.com/questions/320588/interfaces-with-static-fields-in-java-for-sharing-constants)
saying constant in interface is not a good practice. 


> constant final class changed to interface
> -----------------------------------------
>
>                 Key: CARBONDATA-329
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-329
>             Project: CarbonData
>          Issue Type: Improvement
>          Components: core
>            Reporter: abhishek
>            Priority: Trivial
>
> Constant file's is final class and it is now changed to interface. Implicitly fields
are static and final.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message