carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CARBONDATA-329) constant final class changed to interface
Date Wed, 19 Oct 2016 19:07:59 GMT

    [ https://issues.apache.org/jira/browse/CARBONDATA-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15589562#comment-15589562
] 

ASF GitHub Bot commented on CARBONDATA-329:
-------------------------------------------

GitHub user abhishekgiri38 opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/249

    [CARBONDATA-329] constant final class changed to interface

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[CARBONDATA-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
     - [ ] Testing done
     
            Please provide details on 
            - Whether new unit test cases have been added or why no new tests are required?
            - What manual testing you have done?
            - Any additional information to help reviewers in testing this change.
             
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella
JIRA. 
                     
    ---
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/abhishekgiri38/incubator-carbondata master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/249.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #249
    
----
commit e38b01929b16871294effc6eeab37f787e136f00
Author: abhishekgiri38 <abhishek.giri38@hotmail.com>
Date:   2016-10-19T18:55:21Z

    constant file's final class changed to interface

----


> constant final class changed to interface
> -----------------------------------------
>
>                 Key: CARBONDATA-329
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-329
>             Project: CarbonData
>          Issue Type: Improvement
>          Components: core
>            Reporter: abhishek 
>
> Constant file's is final class and it is now changed to interface. Implicitly fields
are static and final.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message