carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CARBONDATA-328) Improve Code and Fix Warnings
Date Mon, 24 Oct 2016 13:04:58 GMT

    [ https://issues.apache.org/jira/browse/CARBONDATA-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15601925#comment-15601925
] 

ASF GitHub Bot commented on CARBONDATA-328:
-------------------------------------------

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/248#discussion_r84681761
  
    --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala
---
    @@ -277,44 +283,43 @@ object CarbonDataRDDFactory extends Logging {
                 compactionModel,
                 lock
               )
    -        }
    -        catch {
    -          case e : Exception =>
    -            logger.error("Exception in start compaction thread. " + e.getMessage)
    +        } catch {
    +          case e: Exception =>
    +            logger.error(s"Exception in start compaction thread. ${ e.getMessage }")
                 lock.unlock()
             }
           }
           else {
             logger
               .audit("Not able to acquire the compaction lock for table " +
    -            s"${carbonLoadModel.getDatabaseName}.${carbonLoadModel.getTableName}"
    +                 s"${ carbonLoadModel.getDatabaseName }.${ carbonLoadModel.getTableName
}"
               )
             logger
    -          .error("Not able to acquire the compaction lock for table " + carbonLoadModel
    -            .getDatabaseName + "." + carbonLoadModel.getTableName
    +          .error(s"Not able to acquire the compaction lock for table" +
    --- End diff --
    
    move to previous line


> Improve Code and Fix Warnings
> -----------------------------
>
>                 Key: CARBONDATA-328
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-328
>             Project: CarbonData
>          Issue Type: Improvement
>            Reporter: Prabhat Kashyap
>            Priority: Trivial
>
> Remove compiler warning and improve the existing code according to the standards. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message