carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CARBONDATA-328) Improve Code and Fix Warnings
Date Fri, 21 Oct 2016 01:16:58 GMT

    [ https://issues.apache.org/jira/browse/CARBONDATA-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15593599#comment-15593599
] 

ASF GitHub Bot commented on CARBONDATA-328:
-------------------------------------------

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/248#discussion_r84404173
  
    --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala
---
    @@ -1043,32 +1050,32 @@ object CarbonDataRDDFactory extends Logging {
             CarbonLoaderUtil.deleteSegment(carbonLoadModel, currentLoadCount)
             logInfo("********clean up done**********")
             logger.audit(s"Data load is failed for " +
    -          s"${carbonLoadModel.getDatabaseName}.${carbonLoadModel.getTableName}")
    +                     s"${ carbonLoadModel.getDatabaseName }.${ carbonLoadModel.getTableName
}")
             logWarning("Cannot write load metadata file as data load failed")
             throw new Exception(errorMessage)
           } else {
    -          val metadataDetails = status(0)._2
    -          if (!isAgg) {
    -            val status = CarbonLoaderUtil
    -              .recordLoadMetadata(currentLoadCount,
    -                metadataDetails,
    -                carbonLoadModel,
    -                loadStatus,
    -                loadStartTime
    -              )
    -            if (!status) {
    -              val errorMessage = "Dataload failed due to failure in table status updation."
    -              logger.audit("Data load is failed for " +
    -                           s"${carbonLoadModel.getDatabaseName}.${carbonLoadModel.getTableName}")
    -              logger.error("Dataload failed due to failure in table status updation.")
    -              throw new Exception(errorMessage)
    -            }
    -          } else if (!carbonLoadModel.isRetentionRequest) {
    -            // TODO : Handle it
    -            logInfo("********Database updated**********")
    +        val metadataDetails = status(0)._2
    +        if (!isAgg) {
    +          val status = CarbonLoaderUtil
    +            .recordLoadMetadata(currentLoadCount,
    --- End diff --
    
    move to previous line


> Improve Code and Fix Warnings
> -----------------------------
>
>                 Key: CARBONDATA-328
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-328
>             Project: CarbonData
>          Issue Type: Improvement
>            Reporter: Prabhat Kashyap
>            Priority: Trivial
>
> Remove compiler warning and improve the existing code according to the standards. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message