carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CARBONDATA-328) Improve Code and Fix Warnings
Date Fri, 21 Oct 2016 01:16:58 GMT

    [ https://issues.apache.org/jira/browse/CARBONDATA-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15593597#comment-15593597
] 

ASF GitHub Bot commented on CARBONDATA-328:
-------------------------------------------

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/248#discussion_r84404993
  
    --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/util/GlobalDictionaryUtil.scala
---
    @@ -413,12 +413,12 @@ object GlobalDictionaryUtil extends Logging {
         // update Metadata
         val catalog = CarbonEnv.getInstance(sqlContext).carbonCatalog
         catalog.updateMetadataByThriftTable(schemaFilePath, tableInfo,
    -        model.table.getDatabaseName, model.table.getTableName, carbonLoadModel.getStorePath)
    +      model.table.getDatabaseName, model.table.getTableName, carbonLoadModel.getStorePath)
     
         // update CarbonDataLoadSchema
         val carbonTable = catalog.lookupRelation1(Option(model.table.getDatabaseName),
    -          model.table.getTableName)(sqlContext)
    -        .asInstanceOf[CarbonRelation].tableMeta.carbonTable
    +      model.table.getTableName)(sqlContext)
    +      .asInstanceOf[CarbonRelation].tableMeta.carbonTable
    --- End diff --
    
    move to previous line if not exceeding 100 characters


> Improve Code and Fix Warnings
> -----------------------------
>
>                 Key: CARBONDATA-328
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-328
>             Project: CarbonData
>          Issue Type: Improvement
>            Reporter: Prabhat Kashyap
>            Priority: Trivial
>
> Remove compiler warning and improve the existing code according to the standards. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message