carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CARBONDATA-328) Improve Code and Fix Warnings
Date Fri, 21 Oct 2016 00:25:58 GMT

    [ https://issues.apache.org/jira/browse/CARBONDATA-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15593475#comment-15593475
] 

ASF GitHub Bot commented on CARBONDATA-328:
-------------------------------------------

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/248#discussion_r84400407
  
    --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataLoadRDD.scala
---
    @@ -196,30 +196,29 @@ class DataFileLoaderRDD[K, V](
       sc.setLocalProperty("spark.scheduler.pool", "DDL")
     
       override def getPartitions: Array[Partition] = {
    -    isTableSplitPartition match {
    -      case true =>
    -        // for table split partition
    -        var splits = Array[TableSplit]()
    -        if (carbonLoadModel.isDirectLoad) {
    -          splits = CarbonQueryUtil.getTableSplitsForDirectLoad(carbonLoadModel.getFactFilePath,
    -            partitioner.nodeList, partitioner.partitionCount)
    -        }
    -        else {
    -          splits = CarbonQueryUtil.getTableSplits(carbonLoadModel.getDatabaseName,
    -            carbonLoadModel.getTableName, null, partitioner)
    -        }
    +    if (isTableSplitPartition) {
    +      // for table split partition
    +      var splits = Array[TableSplit]()
    +      if (carbonLoadModel.isDirectLoad) {
    +        splits = CarbonQueryUtil.getTableSplitsForDirectLoad(carbonLoadModel.getFactFilePath,
    +          partitioner.nodeList, partitioner.partitionCount)
    +      }
    +      else {
    --- End diff --
    
    put to previous line, please modify all places


> Improve Code and Fix Warnings
> -----------------------------
>
>                 Key: CARBONDATA-328
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-328
>             Project: CarbonData
>          Issue Type: Improvement
>            Reporter: Prabhat Kashyap
>            Priority: Trivial
>
> Remove compiler warning and improve the existing code according to the standards. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message