carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CARBONDATA-328) Improve Code and Fix Warnings
Date Fri, 21 Oct 2016 00:25:58 GMT

    [ https://issues.apache.org/jira/browse/CARBONDATA-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15593476#comment-15593476
] 

ASF GitHub Bot commented on CARBONDATA-328:
-------------------------------------------

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/248#discussion_r84400383
  
    --- Diff: integration/spark/src/main/scala/org/apache/carbondata/spark/CarbonFilters.scala
---
    @@ -259,29 +259,29 @@ object CarbonFilters {
                 Some(new NotEqualsExpression(transformExpression(a).get, transformExpression(l).get))
     
             case Not(In(a: Attribute, list))
    -         if !list.exists(!_.isInstanceOf[Literal]) =>
    -         if (list.exists(x => (isNullLiteral(x.asInstanceOf[Literal])))) {
    -          Some(new FalseExpression(transformExpression(a).get))
    -         }
    -        else {
    -          Some(new NotInExpression(transformExpression(a).get,
    +          if !list.exists(!_.isInstanceOf[Literal]) =>
    +          if (list.exists(x => isNullLiteral(x.asInstanceOf[Literal]))) {
    +            Some(new FalseExpression(transformExpression(a).get))
    +          }
    +          else {
    +            Some(new NotInExpression(transformExpression(a).get,
                   new ListExpression(convertToJavaList(list.map(transformExpression(_).get)))))
    -            }
    +          }
             case In(a: Attribute, list) if !list.exists(!_.isInstanceOf[Literal]) =>
               Some(new InExpression(transformExpression(a).get,
                 new ListExpression(convertToJavaList(list.map(transformExpression(_).get)))))
             case Not(In(Cast(a: Attribute, _), list))
               if !list.exists(!_.isInstanceOf[Literal]) =>
    -        /* if any illogical expression comes in NOT IN Filter like
    -         NOT IN('scala',NULL) this will be treated as false expression and will
    -         always return no result. */
    -          if (list.exists(x => (isNullLiteral(x.asInstanceOf[Literal])))) {
    -          Some(new FalseExpression(transformExpression(a).get))
    -         }
    -        else {
    -          Some(new NotInExpression(transformExpression(a).get, new ListExpression(
    +          /* if any illogical expression comes in NOT IN Filter like
    +           NOT IN('scala',NULL) this will be treated as false expression and will
    +           always return no result. */
    +          if (list.exists(x => isNullLiteral(x.asInstanceOf[Literal]))) {
    +            Some(new FalseExpression(transformExpression(a).get))
    +          }
    +          else {
    --- End diff --
    
    put to previous line


> Improve Code and Fix Warnings
> -----------------------------
>
>                 Key: CARBONDATA-328
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-328
>             Project: CarbonData
>          Issue Type: Improvement
>            Reporter: Prabhat Kashyap
>            Priority: Trivial
>
> Remove compiler warning and improve the existing code according to the standards. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message