carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CARBONDATA-328) Improve Code and Fix Warnings
Date Wed, 19 Oct 2016 17:01:05 GMT

    [ https://issues.apache.org/jira/browse/CARBONDATA-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15589263#comment-15589263
] 

ASF GitHub Bot commented on CARBONDATA-328:
-------------------------------------------

GitHub user PKOfficial opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/248

    [CARBONDATA-328] Improve Code and Fix Warnings [Spark]

    Removed some compliation warnings.
    Replace pattern matching for boolean to IF-ELSE.
    Improved code according to scala standards.
    
    
    **Please provide details on** 
    **- Whether new unit test cases have been added or why no new tests are required?**
    Not required because no change in functionality.
    **- What manual testing you have done?**
    Run basic Commands in Beeline.
    **- Any additional information to help reviewers in testing this change.**
    No

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/PKOfficial/incubator-carbondata improved-code-spark

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/248.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #248
    
----
commit 64f169a324e6210fd156b6b5a6acc0916c201616
Author: Prabhat Kashyap <prabhat.kashyap@knoldus.in>
Date:   2016-10-19T16:54:47Z

    Improved spark module code.
    * Removed some compliation warnings.
    * Replace pattern matching for boolean to IF-ELSE.
    * Improved code according to scala standards.

----


> Improve Code and Fix Warnings
> -----------------------------
>
>                 Key: CARBONDATA-328
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-328
>             Project: CarbonData
>          Issue Type: Improvement
>            Reporter: Prabhat Kashyap
>            Priority: Trivial
>
> Remove compiler warning and improve the existing code according to the standards. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message