carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CARBONDATA-311) Log the data size of blocklet during data load.
Date Tue, 18 Oct 2016 04:30:58 GMT

    [ https://issues.apache.org/jira/browse/CARBONDATA-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15584415#comment-15584415
] 

ASF GitHub Bot commented on CARBONDATA-311:
-------------------------------------------

Github user Vimal-Das commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/231#discussion_r83780338
  
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/writer/CarbonFactDataWriterImplForIntIndexAndAggBlock.java
---
    @@ -250,6 +254,7 @@ public NodeHolder buildDataNodeHolder(IndexStorage<int[]>[]
keyStorageArray, byt
         }
         long blockletDataSize =
             holder.getKeyArray().length + holder.getDataArray().length + indexBlockSize;
    +    LOGGER.info("A new blocklet is added, its data size is: " + blockletDataSize + "
Byte");
    --- End diff --
    
    Move this line after call to writeDataToFile, because if writeDataToFile fails, we should
not log that a blocklet is added.


> Log the data size of blocklet during data load.
> -----------------------------------------------
>
>                 Key: CARBONDATA-311
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-311
>             Project: CarbonData
>          Issue Type: Improvement
>    Affects Versions: 0.1.1-incubating
>            Reporter: zhangshunyu
>            Assignee: zhangshunyu
>            Priority: Minor
>             Fix For: 0.2.0-incubating
>
>
> Log the data size of blocklet during data load.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message