carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CARBONDATA-306) block size info should be show in Desc Formatted and executor log
Date Fri, 14 Oct 2016 05:55:20 GMT

    [ https://issues.apache.org/jira/browse/CARBONDATA-306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15574337#comment-15574337
] 

ASF GitHub Bot commented on CARBONDATA-306:
-------------------------------------------

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/230#discussion_r83361557
  
    --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala
---
    @@ -1422,6 +1422,7 @@ private[sql] case class DescribeCommandFormatted(
         results ++= Seq(("Table Name : ", relation.tableMeta.carbonTableIdentifier.getTableName,
""))
         results ++= Seq(("CARBON Store Path : ", relation.tableMeta.storePath, ""))
         val carbonTable = relation.tableMeta.carbonTable
    +    results ++= Seq(("Table Block Size : ", carbonTable.getBlocksize + " MB", ""))
    --- End diff --
    
    If so, can you change the corresponding variable name and function name to indicate it
is bytes in MB,  like `getBlockSizeInMB` and  add comment to `CarbonCommonConstants.TABLE_BLOCKSIZE`


> block size info should be show in Desc Formatted and executor log
> -----------------------------------------------------------------
>
>                 Key: CARBONDATA-306
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-306
>             Project: CarbonData
>          Issue Type: Improvement
>            Reporter: Jay
>            Priority: Minor
>
> when run desc formatted command, the table block size should be show, as well as in executor
log when run load command



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message